Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guidelines for writing a connector #1802

Merged
merged 27 commits into from
Sep 12, 2024
Merged

Guidelines for writing a connector #1802

merged 27 commits into from
Sep 12, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Aug 21, 2024 •
edited
Loading

Description

Closes #1757.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review September 10, 2024 10:08
@hariso hariso requested a review from a team as a code owner September 10, 2024 10:08
@hariso hariso enabled auto-merge (squash) September 10, 2024 10:25
maha-hajja
maha-hajja reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is gold! thank you for this :D

docs/writing-a-connector-guidelines.md Outdated Show resolved Hide resolved
docs/writing-a-connector-guidelines.md Outdated Show resolved Hide resolved
docs/writing-a-connector-guidelines.md Outdated Show resolved Hide resolved
docs/writing-a-connector-guidelines.md Outdated Show resolved Hide resolved
docs/writing-a-connector-guidelines.md Outdated Show resolved Hide resolved
@hariso hariso requested a review from maha-hajja September 12, 2024 11:47
lovromazgon
lovromazgon approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

docs/writing-a-connector-guidelines.md Outdated Show resolved Hide resolved
@hariso hariso merged commit 28cdc80 into main Sep 12, 2024
4 checks passed
@hariso hariso deleted the haris/writing-a-connector-best-practices branch September 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@maha-hajja maha-hajja Awaiting requested review from maha-hajja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document best practices when building connectors
4 participants
@hariso @lovromazgon @maha-hajja @raulb